Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing the point clouds for visualization, for each LiDAR frame, we unnecessarily transform the local map points to the sensor frame to publish it with the same frame as the LiDAR frame. This PR avoids the transformation by directly publishing the local map points in their
frame_id
.We already discussed this in #285. After #371, in which we added the
odom_lidar
to the tf tree, we can now easily publish the local map at thisframe_id
(assuming thatpublish_odom_tf
is set totrue
). Ifpublish_odom_tf
isfalse
, we will now see both the estimated trajectory and the local map because both are published inodom_lidar
, which is the default fixed frame in rviz.This is also how we currently do it in Kinematic-ICP.